Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Add a release pipeline dry run on main #242

Closed
o0Ignition0o opened this issue Dec 3, 2021 · 2 comments · Fixed by #2798
Closed

CI: Add a release pipeline dry run on main #242

o0Ignition0o opened this issue Dec 3, 2021 · 2 comments · Fixed by #2798
Assignees
@abernix

Comments

@o0Ignition0o
Copy link
Contributor

Followup to #241 I had made a mistake that caused the release pipeline build to fail, and couldn't detect it before an actual release attempt.

In order for it to never happen again, we could add a release pipeline dry run on the main branch commits that would run all of the release steps, except the actual publish.

This would allow us to notice this before we add a tag, and make the process a bit more stable
@abernix abernix mentioned this issue Dec 14, 2021
Closed
@abernix abernix mentioned this issue Jan 27, 2022
Closed
@abernix abernix self-assigned this Jan 27, 2022
@abernix abernix removed the triage label May 23, 2022
abernix added a commit that referenced this issue Jan 16, 2023
@abernix
infra: Publish nightly releases of the Router from dev source
d551da5 
Today, when we land features and bug-fixes on `dev`, they require us cutting
a full release before they can be tested by interested/affected parties.

Thanks to work done in #2202 and
#2323, we now have just enough
automation in our release pipeline to take care of some of the necessary
work for building these releases.

With some follow-up work, we can have these triggered through:

- [Manual triggers] through CircleCI
- [Scheduled pipeline] runs in CircleCI

[Scheduled pipeline]: https://circleci.com/docs/scheduled-pipelines/
[Manual triggers]: https://circleci.com/docs/triggers-overview/#run-a-pipeline-from-the-circleci-web-app

This work touches on ideas from
#229 and
#242, though neither of those
issues are _directly_ "build nightly releases", though I did suggest it in
my comments on one of them.
@abernix abernix mentioned this issue Jan 16, 2023
Merged
7 tasks
abernix added a commit that referenced this issue Jan 20, 2023
@abernix
infra: Publish nightly releases of the Router from dev source (#2409)
05ef1d8 
Today, when we land features and bug-fixes on `dev`, they require us
cutting a full release before they can be tested by interested/affected
parties.

Thanks to work done in #2202
and #2323, we now have just
enough automation in our release pipeline to take care of some of the
necessary work for building these releases.

With this work, we can have these triggered through:

- [Manual triggers] through CircleCI
- [Scheduled pipeline] runs in CircleCI

[Scheduled pipeline]: https://circleci.com/docs/scheduled-pipelines/
[Manual triggers]:
https://circleci.com/docs/triggers-overview/#run-a-pipeline-from-the-circleci-web-app

This touches on ideas from
#229 and
#242, though neither of
those issues are _directly_ "build nightly releases", though I did
suggest nightlies in my comments on one of them.

Overall, this creates Router versions of the format
`v0.0.0-nightly+YYYYMMDD.COMMIT_HASH`, which look roughly like
`router-v0.0.0-nightly+20220102.abcd1234-x86_64-unknown-linux-gnu.tar.gz`
as binaries on CircleCI Artifacts.  In the future, we can attach these to  GitHub Releases.
@abernix abernix mentioned this issue Mar 20, 2023
Merged
@abernix
Copy link
Member

abernix commented Mar 20, 2023

This was largely done with #2409, but I've opened #2798 as the final polish I think it needs to be more meaningfully useful.

abernix added a commit that referenced this issue Mar 20, 2023
@abernix
chore: Nightly Release CI Slack notifications (#2798)
be95c10 
This is a small addition to #242 which, when coupled with the already-landed #2409, polishes it off nicely by letting us be notified in advance if a nightly build —which is nearly the entire release process — has succeeded or, more importantly, failed.

Without this, that functionality is less obvious and too easily missed.

Resolves #2409
@abernix abernix linked a pull request Mar 21, 2023 that will close this issue
chore: Nightly Release CI Slack notifications #2798
Merged
@abernix
Copy link
Member

abernix commented Mar 21, 2023

Fixed by #2798

@abernix abernix closed this as completed Mar 21, 2023
tinnou pushed a commit to Netflix-Skunkworks/router that referenced this issue Oct 16, 2023
@clenfest
update release instructions (apollographql#242)
70ebaa1
o0Ignition0o added a commit that referenced this issue Nov 10, 2023
@o0Ignition0o
Merge pull request #242 from apollographql/benjamn/rest_connectors/se…
6aa5e67 
…lection-comments

Support `#`-style comments within `selection` strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abernix abernix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Nightly Release CI Slack notifications apollographql/router
2 participants
@abernix @o0Ignition0o