Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verify that the deferred fragment acts as boundary for nullability rules #2169

Closed
Geal opened this issue Nov 28, 2022 · 0 comments · Fixed by #2183
Closed

verify that the deferred fragment acts as boundary for nullability rules #2169

Geal opened this issue Nov 28, 2022 · 0 comments · Fixed by #2183
Assignees
@garypen
Labels
component/defer

Comments

@Geal
Copy link
Contributor

Geal commented Nov 28, 2022

@defer spec updates mandate that nullability rules should not propagate further than the fragment.
This should be the case already with the router's implementation, but it should be verified
@Geal Geal changed the title verify that the deffered fragment acts as boundary for nullability rules verify that the deferred fragment acts as boundary for nullability rules Nov 28, 2022
garypen added a commit that referenced this issue Nov 30, 2022
@garypen
verify that deferred fragment acts as a boundary for nullability rules
e61c8c3 
fixes: #2169

Add a new test to confirm this is the case.
@garypen garypen mentioned this issue Nov 30, 2022
Merged
garypen added a commit that referenced this issue Dec 1, 2022
@garypen
verify that deferred fragment acts as a boundary for nullability rules (
3b75a35 
#2183)

fixes: #2169

Add a new test to confirm this is the case.
Geal pushed a commit that referenced this issue Dec 2, 2022
@garypen
verify that deferred fragment acts as a boundary for nullability rules (
1f43ad3 
#2183)

fixes: #2169

Add a new test to confirm this is the case.
@BrynCooke BrynCooke modified the milestones: v1-NEXT, v1.5.0 Dec 2, 2022
@garypen garypen added this to the v1.5.0 milestone Dec 5, 2022
@BrynCooke BrynCooke modified the milestone: v1.5.0 Dec 5, 2022
@BrynCooke BrynCooke mentioned this issue Dec 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garypen garypen

Labels
component/defer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

verify that deferred fragment acts as a boundary for nullability rules apollographql/router
3 participants
@garypen @Geal @BrynCooke