Skip to content

Commit

Permalink
Fix config metrics path and test for subscription callbacks (#3688)
Browse files Browse the repository at this point in the history
Fix Apollo metrics for detection of subscription callbacks.
Fixes #3687

<!-- start metadata -->

**Checklist**

Complete the checklist (and note appropriate exceptions) before a final
PR is raised.

- [ ] Changes are compatible[^1]
- [ ] Documentation[^2] completed
- [ ] Performance impact assessed and acceptable
- Tests added and passing[^3]
    - [ ] Unit Tests
    - [ ] Integration Tests
    - [ ] Manual Tests

**Exceptions**

*Note any exceptions here*

**Notes**

[^1]. It may be appropriate to bring upcoming changes to the attention
of other (impacted) groups. Please endeavour to do this before seeking
PR approval. The mechanism for doing this will vary considerably, so use
your judgement as to how and when to do this.
[^2]. Configuration is an important part of many changes. Where
applicable please try to document configuration examples.
[^3]. Tick whichever testing boxes are applicable. If you are adding
Manual Tests:
- please document the manual testing (extensively) in the Exceptions.
- please raise a separate issue to automate the test and label it (or
ask for it to be labeled) as `manual test`
  • Loading branch information
BrynCooke authored Aug 29, 2023
2 parents 709ff0c + e68e64c commit 9316de0
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changesets/fix_bryn_fix_config_metrics.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
### Fix config metrics path and test for subscription callbacks ([Issue #3687](https://github.com/apollographql/router/issues/3687))

Detection of subscription callbacks has been fixed for internal Apollo metrics. This has no user facing impact.

By [@BrynCooke](https://github.com/BrynCooke) in https://github.com/apollographql/router/pull/3688
2 changes: 1 addition & 1 deletion apollo-router/src/configuration/metrics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ impl Metrics {
opt.mode.passthrough,
"$.mode.passthrough",
opt.mode.callback,
"$.mode.callback",
"$.mode.preview_callback",
opt.deduplication,
"$[?(@.enable_deduplication == true)]",
opt.max_opened,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ value.apollo.router.config.subscriptions:
- 1
- opt__deduplication__: "false"
opt__max_opened__: "true"
opt__mode__callback__: "false"
opt__mode__callback__: "true"
opt__mode__passthrough__: "true"
opt__queue_capacity__: "true"

0 comments on commit 9316de0

Please sign in to comment.