Skip to content

Commit

Permalink
Fix metrics typos (#3798)
Browse files Browse the repository at this point in the history
Fix typos:
* timout->timeout
* filtered->authorization.filtered
* needs_authenticated->authorization.authenticated
* needs_requires_scopes->authorization.requires_scopes


<!-- start metadata -->

**Checklist**

Complete the checklist (and note appropriate exceptions) before a final
PR is raised.

- [ ] Changes are compatible[^1]
- [ ] Documentation[^2] completed
- [ ] Performance impact assessed and acceptable
- Tests added and passing[^3]
    - [ ] Unit Tests
    - [ ] Integration Tests
    - [ ] Manual Tests

**Exceptions**

*Note any exceptions here*

**Notes**

[^1]. It may be appropriate to bring upcoming changes to the attention
of other (impacted) groups. Please endeavour to do this before seeking
PR approval. The mechanism for doing this will vary considerably, so use
your judgement as to how and when to do this.
[^2]. Configuration is an important part of many changes. Where
applicable please try to document configuration examples.
[^3]. Tick whichever testing boxes are applicable. If you are adding
Manual Tests:
- please document the manual testing (extensively) in the Exceptions.
- please raise a separate issue to automate the test and label it (or
ask for it to be labeled) as `manual test`

Co-authored-by: bryn <[email protected]>
  • Loading branch information
BrynCooke and bryn authored Sep 11, 2023
1 parent 8f2f059 commit 6015251
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion apollo-router/src/configuration/metrics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ impl Metrics {
log_usage_metrics!(
value.apollo.router.config.traffic_shaping,
"$.traffic_shaping",
opt.router.timout,
opt.router.timeout,
"$$[?(@.router.timeout)]",
opt.router.rate_limit,
"$.router.global_rate_limit",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ value.apollo.router.config.entities:
value.apollo.router.config.traffic_shaping:
- 1
- opt__router__rate_limit__: false
opt__router__timout__: false
opt__router__timeout__: false
opt__subgraph__compression__: false
opt__subgraph__deduplicate_query__: false
opt__subgraph__http2__: false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ expression: "&metrics.metrics"
value.apollo.router.config.traffic_shaping:
- 1
- opt__router__rate_limit__: true
opt__router__timout__: true
opt__router__timeout__: true
opt__subgraph__compression__: true
opt__subgraph__deduplicate_query__: true
opt__subgraph__http2__: true
Expand Down
6 changes: 3 additions & 3 deletions apollo-router/src/plugins/authorization/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -482,9 +482,9 @@ impl Plugin for AuthorizationPlugin {
if needs_authenticated || needs_requires_scopes {
tracing::info!(
monotonic_counter.apollo.router.operations.authorization = 1u64,
filtered = filtered,
authenticated = needs_authenticated,
requires_scopes = needs_requires_scopes,
authorization.filtered = filtered,
authorization.needs_authenticated = needs_authenticated,
authorization.needs_requires_scopes = needs_requires_scopes,
);
}

Expand Down

0 comments on commit 6015251

Please sign in to comment.