Skip to content

Commit

Permalink
Fix metrics attribute types
Browse files Browse the repository at this point in the history
Metrics attributes were being coerced to strings. This is now fixed.
In addition, the logic around types accepted as metrics attributes has been simplified. It will log and ignore values of the wrong type.

Fixes #3691
  • Loading branch information
bryn committed Aug 28, 2023
1 parent 6f3e0c8 commit 3549099
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .changesets/fix_bryn_fix_metrics_typing.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
### Fix metrics attribute types ([Issue #3687](https://github.com/apollographql/router/issues/3687))

Metrics attributes were being coerced to strings. This is now fixed.
In addition, the logic around types accepted as metrics attributes has been simplified. It will log and ignore values of the wrong type.

By [@BrynCooke](https://github.com/BrynCooke) in https://github.com/apollographql/router/pull/3701

0 comments on commit 3549099

Please sign in to comment.