Skip to content

Commit

Permalink
Merge branch 'garypen/3173-ca-certs' into garypen/3140-flush-otlp-met…
Browse files Browse the repository at this point in the history
…rics
  • Loading branch information
garypen committed May 30, 2023
2 parents 413a3a4 + 42d9c73 commit 1bb1825
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 4 deletions.
7 changes: 7 additions & 0 deletions .changesets/fix_garypen_3173_ca_certs.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
### Add ca-certificates to our docker image ([Issue #3173](https://github.com/apollographql/router/issues/3173))

We removed `curl` from our docker images to improve security, which meant that our implicit install of `ca-certificates` (as a dependency of `curl`) was no longer performed.

This fix manually installs the `ca-certificates` package which is required for the router to be able to process TLS requests.

By [@garypen](https://github.com/garypen) in https://github.com/apollographql/router/pull/3174
7 changes: 5 additions & 2 deletions dockerfiles/Dockerfile.router
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,11 @@ WORKDIR /dist

COPY --from=downloader /dist/router /dist

# Update apt
RUN apt-get update -y
# Update apt and install ca-certificates
RUN \
apt-get update -y \
&& apt-get install -y \
ca-certificates

# If debug image, install heaptrack and make a data directory
RUN \
Expand Down
7 changes: 5 additions & 2 deletions dockerfiles/diy/dockerfiles/Dockerfile.repo
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,11 @@ ARG DEBUG_IMAGE=false

WORKDIR /dist

# Update apt
RUN apt-get update -y
# Update apt and install ca-certificates
RUN \
apt-get update -y \
&& apt-get install -y \
ca-certificates

# Copy in the required files from our build image
COPY --from=build --chown=root:root /dist /dist
Expand Down

0 comments on commit 1bb1825

Please sign in to comment.