Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

added inital test coverage for SSR #75

Merged
merged 4 commits into from
Jun 24, 2016
Merged

added inital test coverage for SSR #75

merged 4 commits into from
Jun 24, 2016

Conversation

jbaxleyiii
Copy link
Contributor

This should also make development of SSR features easier to test

Fixes #72

@coveralls
Copy link

coveralls commented Jun 17, 2016

Coverage Status

Coverage increased (+0.09%) to 98.01% when pulling 5a4f5c5 on ssr-start into 93457dc on master.

@stubailo
Copy link
Contributor

Should we merge this? Or is there something else left to do?

@jbaxleyiii
Copy link
Contributor Author

@stubailo @tmeasday said this didn't fix his issue, so I'd like to debug it more when I get some time

@tmeasday
Copy link
Contributor

tmeasday commented Jun 21, 2016

@jbaxleyiii this really seems like it should work (It works when I comment out all the setStates directly in node_modules). I suspect maybe I didn't get the code running correctly after all? I'm not really sure -- perhaps you can give me some pointers about the best way to run this in development

@coveralls
Copy link

coveralls commented Jun 24, 2016

Coverage Status

Coverage decreased (-0.5%) to 97.368% when pulling 91503a3 on ssr-start into 93457dc on master.

@coveralls
Copy link

coveralls commented Jun 24, 2016

Coverage Status

Coverage increased (+0.1%) to 98.02% when pulling d4c3d03 on ssr-start into 93457dc on master.

@coveralls
Copy link

coveralls commented Jun 24, 2016

Coverage Status

Coverage increased (+0.1%) to 98.02% when pulling 2048fec on ssr-start into 93457dc on master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants