convert React.PropTypes to "prop-types" module

[dsifford]

Closes #623

TODO:

• (N/A) If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
• (N/A) Make sure all of the significant new logic is covered by tests
• Rebase your changes on master so that they can be merged easily
• Make sure all tests and linter rules pass
• Update CHANGELOG.md with your change
• (N/A) If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

Note: There's a significant amount of existing lint errors in the test files, but I skipped over them since that is outside the scope of this PR. None are build-breaking because those files aren't actually linted during CI.

[apollo-cla]

@dsifford: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

[stubailo]

This looks great to me.

[stubailo]

@dsifford thanks for contributing!

[happylinks]

Is this released correctly? 1.0.2 doesn't seem to have these fixes.

[dacz]

yes, 1.0.2 still has warnings, unfortunatelly

[ryancole]

In my bundle, the code here appears to still be pulling prop types from react.

react-apollo/src/ApolloProvider.tsx

Lines 22 to 31 in 0754776

	static propTypes = {
	store: PropTypes.shape({
	subscribe: PropTypes.func.isRequired,
	dispatch: PropTypes.func.isRequired,
	getState: PropTypes.func.isRequired,
	}),
	client: PropTypes.object.isRequired,
	immutable: PropTypes.bool,
	children: PropTypes.element.isRequired,
	};

[vladshcherbin]

It was merged after 1.0.2, using master branch is an option to prevent annoying warnings.

[caffo]

Any chance of getting a new version released? I want to upgrade react and the warnings are blocking it. 😄

[helfer]

There's a warning in one of the tests (even though they all pass) that I want to look into. I'll try to release a new version before the weekend.

[dsifford]

Sorry, everybody! Figured converting the deprecations in just react-apollo would cause the warnings to disappear, but clearly, that was not the case.

@helfer Let me know if there's something I can do to help. I feel like this PR is not in good form since its sole purpose has not actually been achieved.

[MichaelDeBoey]

@dsifford If you have refactored every React.PropTypes call to the new PropTypes call, that's all you can do in this repo.
But it's possible you still get the warnings because of dependencies haven't updated their codebase yet.