Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Fix query is required in fetchMore #3065

Merged
merged 3 commits into from
May 28, 2019
Merged

Fix query is required in fetchMore #3065

merged 3 commits into from
May 28, 2019

Conversation

HsuTing
Copy link
Contributor

@HsuTing HsuTing commented May 24, 2019

Fix typescript error about query is required in fetchMore.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • If this was a change that affects the external API used in GitHunt-React, update GitHunt-React and post a link to the PR in the discussion.

@HsuTing HsuTing mentioned this pull request May 24, 2019
Closed
3 tasks
@hwillson
Copy link
Member

Thanks for this @HsuTing. Would you mind adjusting the permissions of this PR on your side, to allow us to make edits?

@HsuTing
Copy link
Contributor Author

HsuTing commented May 28, 2019

@hwillson Done. 😸

hwillson
hwillson approved these changes May 28, 2019
View reviewed changes
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @HsuTing!

@hwillson hwillson merged commit c260cc5 into apollographql:master May 28, 2019
@HsuTing HsuTing deleted the fix-query branch May 29, 2019 01:18
hwillson added a commit that referenced this pull request Jun 3, 2019
@hwillson
Make query optional in the fetchMore signature
45767f6 
Based on #3065.
@hwillson hwillson mentioned this pull request Jun 15, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hwillson hwillson hwillson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HsuTing @hwillson