This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Remove top-level react-dom/server import to fix #2592. #2627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supersedes #2593. Should fix #2592. By pushing the react-dom/server import down into the relevant functions that need it, we can avoid unconditionally importing that dependency tree, which helps in environments like React Native where react-dom/server either doesn't work or seems undesirable (see discussion in #2592). Since the React Native bundler will still try to traverse the require("react-dom/server") dependencies, it's important to prune that dependency with a "react-native": { "react-dom/server": false } section in react-apollo/package.json. Note that this does not prevent React Native apps from using getMarkupFromTree with an appropriate renderFunction; it simply prevents React Native's bundler from bundling the react-dom/server dependency just because react-apollo is imported. Tested with both [email protected] and @0.57.7 (Expo SDKs 30 and 31).
|
Thanks for this. Fixes my issue. Using RN v0.57.3 (no expo) |
|
This also fixes the issue for me using RN 0.57.1 (no Expo). Thanks! |
This was referenced Aug 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #2593.
Should fix #2592.
By pushing the
react-dom/serverimport down into the relevant functions that need it, we can avoid unconditionally importing that dependency tree, which helps in environments like React Native wherereact-dom/servereither doesn't work or seems undesirable (see discussion in #2592).Since the React Native bundler will still try to traverse the
require("react-dom/server")dependencies, it's important to prune that dependency with asection in
react-apollo/package.json. Note that this does not prevent React Native apps from usinggetMarkupFromTreewith an appropriaterenderFunction; it simply prevents React Native's bundler from bundling thereact-dom/serverdependency just becausereact-apollois imported.Tested with both [email protected] and @0.57.7 (Expo SDKs 30 and 31).