This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Adds test for #2508 #2524
Merged
Adds test for #2508 #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apollo Client 2.5 handles `@client` fields locally, which means
when using local resolvers, `@client` fields aren't sent through
AC's configured link chain. To allow people to upgrade to AC 2.5
painlessly, local `@client` handling has to be enabled by
setting local resolvers. If local resolvers aren't set, the
`@client` field is still sent through the link chain.
`MockedProvider` was updated to include a `resolvers` prop, that
can be used to pass local resolvers into the `ApolloClient`
instance it uses internally for testing. The `resolvers` prop
was given a default value of `{}` however, which means AC's
local resolver support is always enabled, and also means that
`MockedProvider` can't be used for tests that require the
`@client` field to be passed through the link chain. When we hit
Apollo Client 3.0, this won't be necessary, but for now we need
to be flexible about this, since people might have updated to
Apollo Client 2.5, but are still using and testing local state
using `apollo-link-state`.
Long story short, this commit removes the `resolvers` default,
which means by default `MockedProvider` isn't using AC 2.5's new
local state handling. It has to be enabled by prodiving
local resolvers via the `MockedProvider` `resolvers` prop.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test to verify that using queries with @client directives are supported by
MockedProviderChecklist:
#2508