Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Fixes #2518 - @connection breaks MockedProvider #2523

Merged

Conversation

ajmath
Copy link
Contributor

@ajmath ajmath commented Oct 22, 2018

When trying to mock a query that uses the @connection directive, the mock would never be triggered due to an inconsistent key in MockLink. This PR adds a method to normalize the incoming mock so that the request made by the apollo client matches the one in MockLink.

See #2518 for more details

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • If this was a change that affects the external API used in GitHunt-React, update GitHunt-React and post a link to the PR in the discussion.

@ajmath ajmath requested review from benjamn and hwillson as code owners March 6, 2019 16:58
@hwillson hwillson self-assigned this Mar 6, 2019
Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @ajmath!

@hwillson hwillson merged commit 051f179 into apollographql:master Mar 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants