-
Notifications
You must be signed in to change notification settings - Fork 787
fix: fetchPolicy support for Subscriptions #2298
fix: fetchPolicy support for Subscriptions #2298
Conversation
@MatthieuLemoine: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
Yes, I agree this is annoying. This is caused by the fact that our docs are auto published after a docs related PR has been merged. This can happen at any point, and isn't tied to a specific release, which is definitely confusing. Honestly I think the best way to address this (and several other repo workflow issues) is to move away from our current |
@hwillson This is a good idea, maybe the issue is less obvious for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MatthieuLemoine!
Hi! 👋
Apollo Client supports
fetchPolicy
for subscriptions but thefetchPolicy
option is not passed to the client in react-apollo.It can be useful when using
no-cache
to avoid automatic cache update & handle the update manually using the new onSubscriptionData.This PR just forwards the
fetchPolicy
option to apollo-client.PS: It could be nice to add some kind of note next to a feature in the documentation with the minimum version number needed to use it. Actually, I tried to set
fetchPolicy
tono-cache
because I thought that I could useonSubscriptionData
to update the cache but it seems that it was only merged yesterday.