This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Use client store. #222
Merged
Use client store. #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just in case one's using an immutable store.
|
@amsayk: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
|
@amsayk could you add these changes to the changelog? |
|
@jbaxleyiii I updated the change log in another pull request #225. Also opened issue #224 to track this. Feel free to close when you merge this. |
|
On another subject, it would be great to have react-apollo work out of the box with immutable like redux-form by exposing I don't know how feasible it would be or if its best for performance. But if you're open to it, I could send PR. |
|
@amsayk what are your thoughts on how to accomplish it? I'm open to it for sure! |
jbaxleyiii
pushed a commit
that referenced
this pull request
Sep 22, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just in case one's using an immutable store.