Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Custom client on Mutations #1943

Closed
wants to merge 2 commits into from
Closed

Custom client on Mutations #1943

wants to merge 2 commits into from

Conversation

GuteFCO
Copy link

@GuteFCO GuteFCO commented Apr 24, 2018

Added the possibility to define a custom client in mutations, based on Query component

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • If this was a change that affects the external API used in GitHunt-React, update GitHunt-React and post a link to the PR in the discussion.

Added the possibility to define a custom client in mutations, based on Query component
@apollo-cla
Copy link

@GuteFCO: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@GuteFCO GuteFCO changed the title Update Mutation.tsx Define a custom client on Mutations Apr 24, 2018
@GuteFCO GuteFCO changed the title Define a custom client on Mutations Custom client on Mutations Apr 24, 2018
@samyhrer
Copy link

Great PR! But to consolidate the API surface, this feature should maybe be added to the Query and Subscription component as well?

@hwillson
Copy link
Member

This was already implemented in #1890 and released in react-apollo 2.1.6. Thanks for submitting this PR though!

@hwillson hwillson closed this Jun 21, 2018
@samyhrer
Copy link

@hwillson Do you know if there are plans to do this for the Subscription-component as well? Or will you accept a PR for that functionality?

@hwillson
Copy link
Member

@samyhrer I'd love a PR that adds that functionality!

@hwillson
Copy link
Member

@samyhrer Actually, maybe hold off on that PR. I just noticed #1956 implements this across the board. Thanks though!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants