Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Typescript example update #1471

Merged
merged 11 commits into from
Dec 27, 2017
Merged

Conversation

rosskevin
Copy link
Contributor

@rosskevin rosskevin commented Dec 27, 2017

Working on upgrading the typescript example to use the lates apollo-codegen with typescript-modern and the Query render callback component.

I have tried to use src/ direct from the example and have fixed various type usage issues found in the source, though should be no runtime changes. This is going to need to be handled bit by bit to get it updated and running.

@apollo-cla
Copy link

apollo-cla commented Dec 27, 2017

Warnings
⚠️

❗ Big PR

Generated by 🚫 dangerJS

@rosskevin
Copy link
Contributor Author

I'm actually not sure what is left here - as the relative imports don't work and we need them. The goal here is to get this dir to work with https://codesandbox.io

@rosskevin rosskevin merged commit 8f339f1 into apollographql:master Dec 27, 2017
@rosskevin rosskevin deleted the examples-update branch December 27, 2017 20:32
@rohmanhm
Copy link

rohmanhm commented Jan 8, 2018

Hi, thanks for the great example.
Is it already done?

I found this line trying to import Query and QueryResult from react-apollo which do not exist on typescript definition from react-apollo

import { Query, QueryResult } from 'react-apollo';

Is it really works? Can you explain more? I got confused right now.

@rosskevin
Copy link
Contributor Author

The example is not done and those components are only on master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants