-
Notifications
You must be signed in to change notification settings - Fork 786
Included tests by adding .test extension #1448
Included tests by adding .test extension #1448
Conversation
…into fix-jest-test-query
looks good but tests aren't running again due to what looks like a conflict again with prettier/tslint. I've never used that package you added so not sure if it actually solves it here. |
Generated by 🚫 dangerJS |
cc @rosskevin, I finally fixed the tests:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little tentative on just matching snapshots because they can be easily updated/committed, but all the same it is a reliable assertion method - we probably need to lockdown PR merge settings so that at least one review is required before merging to ensure no bad snapshot updates.
I agree with you. I was hesitant to update to snapshots as well but I found no other clean way to run the assertions. Note, other test files use a |
I had to add |
Included Query.test.js and test-utils.test.js into the test suite by adding the .test extension.