-
Notifications
You must be signed in to change notification settings - Fork 786
add notifyOnLoadingStatusChange to fix issue #1347 #1438
Conversation
Redefine function refetch() on the graphql hoc, and we do forceUpdate in this function and call the original refetch function. The graphql re-render can pass the right props through calling dataForChild();
@tonyjiang88215: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
* redefine refetch function, if option.notifyOnLoadingStatusChange is true, we forceUpdate * after calling original refetch to pass the new dataProps to the wrappedComponent. * That can makes WrappedComponent be able to watch on loading status;
add changlog
At least version, i set up a |
@tonyjiang88215 please note that I am not neglecting this PR, I simply am not familiar enough to make a call on it. @jbaxleyiii will be back soon, so I'll let him review. @excitement-engineer any change we adopt here we should probably see how it impacts |
@rosskevin thanks for feeding back. In my option, i think the It`s all right if this PR is not accept , i can still do it in my project. : ) Thanks for the time again. |
@tonyjiang88215 I think this is already supported by using |
Closes #1347
Redefine function refetch() on the graphql hoc, and we do forceUpdate in this function and call the original refetch function.The graphql re-render can pass the right props through calling dataForChild();