Wrapped component never gets updated after an error

[jer-sen]

Intended outcome:
I have a React component wrapped with the graphql function to get data from a GraphQL query.
The query is called on mounting, on this.props.data.refetch(), or at some time if pollInterval is set.
If any of these calls fails, I expect the component to be updated if a new call succeed, so that:

• I can add a "Retry" button to let the user manually trigger a refetch if the first call on mounting failed. If the refetch succeeds then the data.error prop changes to undefined and the component gets updated with the data received.
• If pollInterval is set and if at some point the network connection is lost, then when the connection is back the polling works as if the connection was never lost. So I want the polling to continue even if a poll has failed in the past and I want the component to be updated if new data is available (coming from a new poll of the same request or from the result of any other query or mutation in the app)

Actual outcome:
After an error, data.error remains defined and component never gets updated, even if data.refetch is called or if pollInterval is set.

My understanding:
Basically, when there is a network error, observers are unsubscribed. Thus any refetch only update Apollo store but does not trigger a rerender of the component.
I think it's the expected behaviour of the cleanupSubscription call in https://github.com/apollographql/apollo-link/blob/master/packages/zen-observable-ts/src/zenObservable.ts
Which is called through obs.error(error) in https://github.com/apollographql/apollo-client/blob/master/packages/apollo-client/src/core/ObservableQuery.ts
But I think react-apollo should resubscribe to the query after an error to keep the component updated when new data arrive in the cache (after a data.refetch, a poll, or any other query or mutation in the app).

Version

• [email protected]
• [email protected]

This is the issue asked here apollographql/apollo-client#1186 (comment)

[stale]

This issue has been automatically labled because it has not had recent activity. If you have not received a response from anyone, please mention the repository maintainer (most likely @jbaxleyiii). It will be closed if no further activity occurs. Thank you for your contributions to React Apollo!

[jer-sen]

Hey !

[msmfsd]

BUMP - this is an important issue with v2 - can someone please look at this?

Basically data.error is not cleared on refetch.

[lnikkila]

We’re seeing this as well with newer versions of dependencies:

[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]

[leethree]

I'm seeing the same problem with React-Apollo 2.0. The wrapped components are not re-rendered after data.refetch().

[msmfsd]

related to apollographql/apollo-client#2513

[jozanza]

Setting pollInterval also seems to have no effect for me in [email protected] and [email protected]

[slonoed]

Did anyone found a workaround for it?

[jer-sen]

@slonoed you can change

                        assign(data, (this.queryObservable.getLastResult() || {}).data);

by

                        assign(data, (this.queryObservable.getLastResult() || {}).data, { retry: () => {
													this.unsubscribeFromQuery();
													this.queryObservable = null;
													this.previousData = {};
			                    this.updateQuery(this.props);
			                    if (!this.shouldSkip(this.props)) {
			                        this.subscribeToQuery();
			                    }
												} });

around line 560 of node_modules/react-apollo/react-apollo.browser.umd.js

It will pass a retry function to the component that you can call with this.props.data.retry().

[slonoed]

@Jay1337 thanks! I don't really want to change library code.
Did you consider to make a PR?

Also, I'm curious:
Is it possible to spin up a new query from app code?

[jer-sen]

I don't have time for a PR and I don't think it would be merged (since maintainers don't seem to have time for github issues...). You can fork the repo and apply my patch if you need it. I forgot to mention that the retry function will be available only when there is an error (this.props.data.error = true). Le 23 janv. 2018 15:39, "Dmitry Manannikov" <[email protected]> a écrit :

…

@Jay1337 <https://github.com/jay1337> thanks! I don't really want to change library code. Did you consider to make a PR? Also, I'm curious: Is it possible to spin up a new query from app code? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1229 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACBSLSK0_dGo06FtityoWTaMKOAlfyAuks5tNe8IgaJpZM4P1IG2> .

[0m15]

any news about this issue? I'm experiencing it as well with freshly installed apollo client:

"react-apollo": "^2.0.4"
"apollo-client-preset": "^1.0.6"

[mephju]

I'm also experiencing this.
"apollo-client": "^2.2.8"
"react-apollo": "^2.1.3"

[jasonpaulos]

Hi everyone! PR #3107 solves the problem of resubscribing to the observable after all errors. If anyone still wants to pursue an explicitly 'retry' mechanism, I suggest that you make an issue here: https://github.com/apollographql/apollo-feature-requests/issues Thanks!