This repository has been archived by the owner on Jan 15, 2020. It is now read-only.
Add eslin+prettier & use rawCollection for the user lookup #82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about quality control & provide a consistent package (I hope!) along its future releases.
It sets up ESLint & prettier. So far so good, the package is still running & usable in a Meteor app but... it broke the tests with the dreaded
Error: Can't wait without a fiber
😵 (screenshot).➡️ Using directly the npm mongo driver with
Meteors.users.rawCollection()
solved this testing problem (and a Meteor app running with the package still receive data from the server):Fibers-aware queries sent to the server are handled thanks to apollographql/apollo-server#92
Thus I believe there is also no need for
Meteor.bindEnvironment
as we are not running anymore Fibers-aware code on the GraphQL server creation? 🤔 cc/ @stubailo @helfer