Fix graphql-tag/loader by properly stringifying GraphQL source
#65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i understand how to fix this, so will try and get a proper fix submitted this week |
[Loc.prototype.toJson](https://github.com/graphql/graphql-js/blob/77f2785e6c740a95e7615dad41e4ac1b663cea0e/src/language/parser.js#L1048-L1050) will never return the `source` key (which holds the stringified version of the query that we need when using the Webpack loader. We'll manually add it since the reference to `source` still exists on `doc.loc`
jnwng
changed the title
graphql-tag/loader by properly stringifying GraphQL source
|
This looks good! Seems to properly work around the change that made |
stubailo
approved these changes
May 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion on #64, the
source(which is part of the GraphQL document) was not properly being stringified and cached in the javascript being generated by the Webpack loader, which caused issues when attempting to interpolate documents retrieved via said loader.