Fix duplicate queries in named exports #170
Conversation
Recent changes to the loader exported queries as individual named exports, but each such export erroneously included the previous exports.
loader.js
Outdated
| // Make copy before named exports are added to the doc | ||
| // see https://github.com/apollographql/graphql-tag/issues/168 | ||
| outputCode += ` | ||
| var docCopy = Object.assign({}, doc); |
There was a problem hiding this comment.
this is partially my fault for not establishing what our compatibility matrix is, but this almost certain will break for ie 11. is it possible to use an alternative method here to assign / clone this object?
There was a problem hiding this comment.
Sure. The only properties on GraphQL AST's are kind, definitions, and loc, right? Would you like me to change the other instances of Object.assign() while I'm at it?
There was a problem hiding this comment.
ah, yes, i didnt notice that we had those in there as well. if its not too much trouble, that would be great! otherwise im happy to merge this and we can address the compatibility issue afterwards (since its already an issue)
|
thanks for the pr @wacii, certainly appreciated. just one question but otherwise looks fine to proceed |
wacii
force-pushed
the
fix-nested-queries
branch
from
efe7078
to
f6fd7bc
Compare
|
Merge that, merge it, merge now. It's really bad bug! |
Recent changes to the loader exported queries as individual named exports, but each such export erroneously included the previous exports. This gets big fast.
Closes #168