-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[loader] Add "use strict" or document node 6 requirement #39
Comments
there's nothing in the webpack loader that would necessitate a hard dependency on node 6, so i would hesitate to suggest enforcing that. there's a couple of solutions here:
while i'd prefer that we do the former (compiling the loader), i'd be happy to accept a PR with the latter (adding |
linking with #32 as i suspect this will be something to address when the webpack loader is extracted |
Added 'use strict'; to loader.js in order to fix apollographql#39
addressed by #41. @pward123 unfortunately didn't see that you had created this in your fork, in the future you can send a pull request so that we can pull your code back into this repository. |
I get the following error when using the loader in webpack 2 with node 4.6.1:
Module build failed: SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode
This can be fixed by adding
"use strict";
to the top of loader.js or switching to node 6. I'm not sure if you want to add strict mode or document the requirement.The text was updated successfully, but these errors were encountered: