fix(gateway): Remove path, query and variables field from subgraph error responses
#900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevor-scheer
changed the title
query and variables field from subgraph error responses
trevor-scheer
commented
Jul 21, 2021
trevor-scheer
commented
Jul 21, 2021
abernix
approved these changes
Jul 21, 2021
trevor-scheer
changed the title
query and variables field from subgraph error responsespath, query and variables field from subgraph error responses
trevor-scheer
added a commit
that referenced
this pull request
Jul 21, 2021
Release * @apollo/[email protected] * @apollo/[email protected] * @apollo/[email protected] * @apollo/[email protected] PRs: * feat(gateway): Default to Uplink for composed supergraph managed federation (#881) * fix(federation): Require user-defined @tag directive definition (#882) * Remove @inaccessible elements when converting to API schema (#807) * Move toAPISchema call into try/catch block (#894) * fix(gateway): Prevent inaccessible type names from being leaked in error messages (#893) * docs: rm instruction to set APOLLO_SCHEMA_CONFIG_DELIVERY_ENDPOINT for Uplink (#899) * fix(gateway): Remove path, query and variables field from subgraph error responses (#900)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queries and variables coming from the gateway down to subgraphs can contain sensitive information that shouldn't be passed back to the client. Currently this can happen when an error occurs during a gateway fetch to a subgraph, and those errors are subsequently returned to the client in the response's error extensions.
We should just remove these fields. There is more discussion to be had around returning error information of this sort at all, but for now this is a sensible first step and prevents leaking potentially immediately sensitive information.