Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove out-of-band error reporting in the gateway #2946

Merged
merged 2 commits into from
Feb 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/serious-pumas-hear.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@apollo/gateway": patch
---

Remove out-of-band reporting in the gateway and provide a warning for users who have the endpoint configured.
2 changes: 0 additions & 2 deletions codegen.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
overwrite: true
schema: [
"https://uplink.api.apollographql.com/",
"https://outofbandreporter.api.apollographql.com/",
]
documents:
- gateway-js/src/supergraphManagers/UplinkSupergraphManager/loadSupergraphSdlFromStorage.ts
- gateway-js/src/supergraphManagers/UplinkSupergraphManager/outOfBandReporter.ts
generates:
gateway-js/src/__generated__/graphqlTypes.ts:
plugins:
Expand Down
62 changes: 0 additions & 62 deletions gateway-js/src/__generated__/graphqlTypes.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 0 additions & 18 deletions gateway-js/src/__tests__/integration/nockMocks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,6 @@ export const mockCloudConfigUrl2 =
export const mockCloudConfigUrl3 =
'https://example3.cloud-config-url.com/cloudconfig/';

export const mockOutOfBandReporterUrl =
'https://example.outofbandreporter.com/monitoring/';

export function mockSupergraphSdlRequestIfAfter(ifAfter: string | null, url: string | RegExp = mockCloudConfigUrl1) {
return gatewayNock(url).post('/', {
query: SUPERGRAPH_SDL_QUERY,
Expand Down Expand Up @@ -140,18 +137,3 @@ export function mockSupergraphSdlRequestIfAfterUnchanged(
export function mockSupergraphSdlRequestSuccess({supergraphSdl = getTestingSupergraphSdl(), url = mockCloudConfigUrl1}: {supergraphSdl?: string, url?: string | RegExp} = {}) {
return mockSupergraphSdlRequestSuccessIfAfter(null, undefined, supergraphSdl, url);
}

export function mockOutOfBandReportRequest() {
return gatewayNock(mockOutOfBandReporterUrl).post('/', () => true);
}

export function mockOutOfBandReportRequestSuccess() {
return mockOutOfBandReportRequest().reply(
200,
JSON.stringify({
data: {
reportError: true
},
}),
);
}
Loading