Fix issue where @defer condition gets ignored #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a blunder that got overlooked: the `DeferNormalizer.init` method had meant to be updated when condition were added to record if we had any defer with either "no explicit label" or "some condition", and the name of the variable keeping that information was updated, but somehow forgot to actually set the variable for "some condition". This wasn't caught by the existing tests because none of the condition unit tests was using an explicit label, so the variable mentioned above ended up being set for the "wrong" reason. Anyway, this commit fixes the issue and adds test coverage. Fixes apollographql#2100
👷 Deploy request for apollo-federation-docs pending review.Visit the deploys page to approve it
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
clenfest
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a blunder that got overlooked: the
DeferNormalizer.initmethodhad meant to be updated when condition were added to record if we had
any defer with either "no explicit label" or "some condition", and the name
of the variable keeping that information was updated, but somehow forgot
to actually set the variable for "some condition".
This wasn't caught by the existing tests because none of the condition
unit tests was using an explicit label, so the variable mentioned above
ended up being set for the "wrong" reason.
Anyway, this commit fixes the issue and adds test coverage.
Fixes #2100