__resolveReference follow-ups
#1757
Conversation
✅ Deploy Preview for apollo-federation-docs canceled.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
| }, | ||
| }; | ||
| } else if (fieldName.startsWith("__")) { | ||
| (type as any)[fieldName.substring(2)] = fieldConfig; | ||
| continue; |
There was a problem hiding this comment.
Note to reviewer: I restored this continue in the resolveReference case, which previously existed here: https://github.com/apollographql/federation/pull/1746/files#diff-89b6c52a33464884610c771bf9c04484fc8acf56fb57fd9a31b168dd55595530R181
Bit tough to see with the diff. No effect on tests with or without.
There was a problem hiding this comment.
Good catch — sorry for missing that in the last review. I guess technically a no-op since fieldMap['__resolveReference'] shouldn't be truthy.
| }, | ||
| }; | ||
| } else if (fieldName.startsWith("__")) { | ||
| (type as any)[fieldName.substring(2)] = fieldConfig; | ||
| continue; |
There was a problem hiding this comment.
Good catch — sorry for missing that in the last review. I guess technically a no-op since fieldMap['__resolveReference'] shouldn't be truthy.
* Support __isTypeOf * Reference src instead of dist aross packages
Addressing feedback from #1746
The vague
"__"is unhelpful here. We're not expecting a bunch of things to be prefixed with__(it violates the spec to do so, albeit a useful hack in the past https://spec.graphql.org/October2021/#sec-Objects.Type-Validation).__resolveReferenceand__resolveType)schema-helper(which is only needed for gateway's test code, not runtime)