Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js-repo-migration] Give Cradle tests a singular home in this repo #145

Open
abernix opened this issue Sep 10, 2020 · 2 comments
Open

[js-repo-migration] Give Cradle tests a singular home in this repo #145

abernix opened this issue Sep 10, 2020 · 2 comments
Assignees

Comments

@abernix
Copy link
Member

abernix commented Sep 10, 2020

With #134, the .feature Cucumber files which lived in apollo-server will now live in this repository. The copies that existed in apollo-server had previously been acting as the single source of truth, but we were copying them (manually) over to this repository in order to verify the conformance of the new Rust query planner.

That means there are now two copies in this repository! We should move them into a (likely, top-level) folder and give them a README on how to use them and remove the duplicated copies in a way that allows the places they are depended on (within this repo) to rely on the single source of truth.

@JakeDawkins
Copy link
Contributor

This is great! Do you think we can version these files in some way? Even if it's a line in the readme? Just to make it easier to track changes

@Enrico2
Copy link
Contributor

Enrico2 commented Sep 10, 2020

When copying over those .feature files from the PR to the Rust repo, we had to change a couple of minor things. The only one that pops to mind is some place with different field ordering where Rust actually did the right thing, once we switch to a single source of truth for the .feature files, we'll need to fix that "bug" in JS.

I think this was the change: 2f81460 (#113)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants