Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a home for Cradle, the query-planner compatibility acceptance tests #104

Closed
abernix opened this issue Jul 9, 2020 · 1 comment
Closed

Comments

@abernix
Copy link
Member

abernix commented Jul 9, 2020

apollographql/apollo-server#4297 introduced what are meant to be language-agnostic compatibility acceptance tests for query-plans. For now, Cucumber ".feature files" are the extent of this testing, but we believe this is just the beginning of a larger federation test-suite — which we're calling Cradle — that can satisfy testing requirements of various initiatives.

For example, when #103 has brought these tests into this repository, the work in #101 can take place and build a query-planner (in Rust!) that meets the expectations of the test-suite.

Thankfully, manually copying the files into this repository to maintain test-completeness is not our end-game. Furthermore, the Apollo Server repository should not remain the source of truth for those files. Cradle needs a home repository which will house its documentation and allow it to be utilized by other projects.

We need to figure out the details of how that work! (And this is the issue to discuss that in, if anyone has ideas!)

Incredibly naive, half-baked, straw-dog proposal: A separate repository that can be used as a Git submodule (or git subtree).

@abernix
Copy link
Member Author

abernix commented Sep 10, 2020

This repository will be the home! See #145 for tracking that progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant