poc: PooledPlanner + choice of 2 load balancing #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuorig
changed the title
xuorig
force-pushed
the
worker-planner-pool
branch
from
95b3440
to
4ec590b
Compare
xuorig
force-pushed
the
worker-planner-pool
branch
from
4ec590b
to
5ab543f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploying new instances of apollo-router almost inevitably ends up with a spike in timeouts. Initially thinking this was due to large query plans / done in JS (related), it is instead mostly due to the synchronous nature of the planner, with a ton of queuing happening for new instances receiving a high cardinality of new queries to plan.
There is a ton of gotchas with using a pool of planners. Errors especially are hard to recover from. I'm going to use this branch to test things out and see what kinds of improvements could be achieved.