Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve identity template literal tag docs #254

Merged
merged 3 commits into from
Dec 27, 2019

Conversation

jaydenseric
Copy link
Contributor

@jaydenseric jaydenseric commented Nov 14, 2019

This PR improves the identity template literal tag docs:

  • Tweaked the text from saying tags are “always” used in Apollo projects to “often”, as there are situations where tags are not necessary like when making server side queries via node-fetch that come up in real world projects.
  • Replaced the manual copy paste fake tag code with the suggestion to use fake-tag. This utility is easy to install and use and has tests covering Interpolations and escapes. It has been reasonably battle tested.
  • Mentioned the /* GraphQL */ comment tag enhancement issue (Support /* GraphQL */ comment tags #224).

See earlier discussion: #224 (comment)

TODO:

  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests pass
  • Update CHANGELOG.md with your change
  • If this was a change that affects the external API, update the README

@jaydenseric jaydenseric marked this pull request as ready for review November 14, 2019 02:00
@jnwng jnwng merged commit a1a7517 into apollographql:master Dec 27, 2019
@jaydenseric jaydenseric deleted the fake-tag-docs branch March 18, 2020 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants