Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for [email protected] and [email protected] #119

Merged
merged 5 commits into from
Apr 15, 2018

Conversation

jnwng
Copy link
Contributor

@jnwng jnwng commented Mar 22, 2018

Also added some infra to make sure we run tests against all possible versions.

This is a major breaking change — it fails a few tests and its not worth diverging the tests based on version to avoid the major bump. There's also some complications with libraries like graphql-config not properly supporting custom named "Query" types, but shouldn't affect a large amount of people.

TODO:

  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests pass
  • Update CHANGELOG.md with your change
  • If this was a change that affects the external API, update the README

Pull Request Labels

  • feature
  • blocking
  • docs

@jnwng jnwng requested a review from stubailo March 22, 2018 19:31
@ghost ghost added the feature New addition or enhancement to existing solutions label Mar 22, 2018
@jnwng jnwng force-pushed the jw/graphql-12-13 branch from f57fbba to d883e14 Compare April 6, 2018 01:09
@jnwng jnwng force-pushed the jw/graphql-12-13 branch from 4502f01 to 8a18b6c Compare April 6, 2018 01:16
@lgandecki
Copy link

This would be fantastic to have, for now, I'm using a custom npm package based on @jnwng fork :
https://www.npmjs.com/package/eslint-plugin-graphql-next

@jnwng jnwng merged commit d624301 into apollographql:master Apr 15, 2018
@jnwng jnwng deleted the jw/graphql-12-13 branch April 15, 2018 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New addition or enhancement to existing solutions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants