Disable NoUnusedVariablesRule by default to relay

apollographql · Mar 11, 2021 · c99d1b3 · c99d1b3
1 parent c465fed
commit c99d1b3
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,7 +2,7 @@
 
 ### vNEXT
 
-- _Nothing yet!_
+- Disable `NoUnusedVariables` validator by default into `relay` mode. [PR #298](https://github.com/apollographql/eslint-plugin-graphql/pull/298) by [gtkatakura](https://github.com/gtkatakura)
 
 ### v4.0.0
 

diff --git a/README.md b/README.md
@@ -340,7 +340,7 @@ The full list of available validators is:
   - `NoFragmentCycles`
   - `NoUndefinedVariables` (*disabled by default in `relay`*)
   - `NoUnusedFragments` (*disabled by default in all envs*)
-  - `NoUnusedVariables`
+  - `NoUnusedVariables` (*disabled by default in `relay`*)
   - `OverlappingFieldsCanBeMerged`
   - `PossibleFragmentSpreads`
   - `ProvidedRequiredArguments` (*disabled by default in `relay`*)

diff --git a/src/index.js b/src/index.js
@@ -49,11 +49,13 @@ const envGraphQLValidatorNames = {
     "KnownFragmentNames",
     "NoUndefinedVariables",
     "NoUnusedFragments",
+    "NoUnusedVariables",
     // `graphql`@15
     "KnownDirectivesRule",
     "KnownFragmentNamesRule",
     "NoUndefinedVariablesRule",
     "NoUnusedFragmentsRule",
+    "NoUnusedVariablesRule",
     // `graphql` < 14
     "ProvidedNonNullArguments",
     // `graphql`@14

diff --git a/test/env/relay.js b/test/env/relay.js
@@ -97,6 +97,17 @@ ruleTester.run('relay', rule, {
           events
         }
       }\`
+    `,
+    `
+      Relay.QL\`
+        query StoresListQuery(
+          $count: Int
+          $cursor: String
+          $search: String
+        ) {
+          ...StoresList_stores
+        }
+      \`
     `
   ].map((code) => ({ options, parser, code })),