Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A possible implementation that exposes some cache metrics. #328

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stevengssns
Copy link

Hello,

at the project I'm working on in my day job we are using this library already for a while in production. It is doing a fine job so far, but we are starting to encounter a few limitations.

So I have made an attempt at tackling the first and easiest one of them. Exposing information about how the cache was used when receiving a fetch result.

I have done a quick test using our project code, and everything seems to be working. But before I try to add the necessary unit tests, I would of course first like to get feedback about this solution.

At least partially fixes #41

@stevengssns stevengssns requested a review from a team as a code owner April 7, 2024 15:30
@apollo-cla
Copy link

@stevengssns: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link

codesandbox-ci bot commented Apr 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@stevengssns stevengssns marked this pull request as draft April 8, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[apollo-datasource-rest] Feature request: expose cache status to callers
2 participants