This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
[GM-835] Change --tag references to --variant for commands #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zionts
commented
Mar 25, 2020
| @@ -35,7 +35,7 @@ The rest of this article focuses on managing a federated graph with the Apollo p | |||
|
|
|||
| If you're running a distributed GraphQL infrastructure, where federated services [compose](https://www.apollographql.com/docs/apollo-server/federation/federation-spec/#fetch-service-capabilities) to form a complete schema, tracking the history of the graph and its underlying services is essential. Running `apollo service:push` from within CI/CD on any federated service registers the overall schema of the graph and updates the graph's [managed configuration](#managed-configuration). | |||
|
|
|||
| To push a single federated service to Apollo, run `apollo service:push` in CI/CD with the `--serviceName`, `--endpoint`, and `--serviceURL` tags. The CLI will know where to fetch your service's capabilities based on the `--endpoint` flag, and the `--serviceURL` flag indicates where the federated service can be reached by the gateway. The `--serviceName` flag is used as a unique identifier for each federated service. | |||
| To push a single federated service to Apollo, run `apollo service:push` in CI/CD with the `--serviceName`, `--endpoint`, and `--serviceURL` flags. The CLI will know where to fetch your service's capabilities based on the `--endpoint` flag, and the `--serviceURL` flag indicates where the federated service can be reached by the gateway. The `--serviceName` flag is used as a unique identifier for each federated service. | |||
There was a problem hiding this comment.
this was just a typo fix
zionts
commented
Mar 25, 2020
|
|
||
| To specify the schema tag to register operations on, pass an additional `--tag <TAG>` argument (`npx apollo client:push --tag <TAG>`). | ||
| To specify the schema variant to register operations on, pass an additional `--variant <VARIANT>` argument (`npx apollo client:push --variant <VARIANT>`). |
There was a problem hiding this comment.
This should really be graph variant
zionts
commented
Mar 25, 2020
| @@ -213,9 +213,9 @@ const gateway = new ApolloGateway({ | |||
|
|
|||
| </ExpansionPanel> | |||
|
|
|||
| #### 5.1 Optionally, set the schema tag | |||
| #### 5.1 Optionally, set the graph variant (AKA schemaTag) | |||
There was a problem hiding this comment.
leaving this reference since the Apollo Server / plugin option is still schemaTag
zionts
commented
Mar 25, 2020
| @@ -340,8 +340,8 @@ const server = new ApolloServer({ | |||
| willUpdateManifest(newManifest, oldManifest) { | |||
| metrics.report( | |||
| "safelist.numberOperations", | |||
| newManifest && | |||
| newManifest.operations && | |||
| newManifest && | |||
There was a problem hiding this comment.
My VS Code did this automatically? 🤷♂
4 tasks
StephenBarlow
approved these changes
Mar 25, 2020
This is to support a change to the command line tool to prefer using --variant to --tag and deprecate the latter.
zionts
force-pushed
the
adam/20/3/tag-is-deprecated
branch
from
88e4d92
to
cd07760
Compare
zionts
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support a change to the command line tool to prefer using
--variant to --tag and deprecate the latter. Please see apollographql/apollo-tooling#1849 for reference! We should correspond timing of the two :)