Add option to keep schema enum order for code generating #2043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@viico: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
viico
force-pushed
the
keepSchemaEnumOrder
branch
from
47eeea4 to
a05d4cc
Compare
viico
force-pushed
the
keepSchemaEnumOrder
branch
from
a05d4cc to
59a8c7d
Compare
|
I fixed unit tests but "ci/circleci: NodeJS 10" still failing, I don't see why. |
|
this bug has been a thorn in our side for a while now ... anything i can do to help push this merge along? happy to help just LMK |
|
We also faced the same problem.. anything we can do to push it? |
viico
force-pushed
the
keepSchemaEnumOrder
branch
from
59a8c7d to
ad0ee7e
Compare
|
Can this be pushed to the main branch? This bug is really a big issue for us. |
|
This is a major issue. We now need to create duplicates of the enums in order to support the existing code of the client. This is terrible. |
|
Is this completely forgotten feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is a PR related to issue #1760. We want to can keep schema enum order when generating code and not sort them alphabetically. This PR keep sort by default but add an option to don't.
I added a test and I update only for typescript generation. I don't know if it could be interesting for another generation.
TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.