-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate optional TypeScript fields when @include or @skip directive is used #1854
Generate optional TypeScript fields when @include or @skip directive is used #1854
Conversation
@mwilliamson: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
96ef2f9
to
24be1a4
Compare
Does this support |
24be1a4
to
2550fc1
Compare
Yes, I've also signed the CLA. |
Very much appreciated, @mwilliamson! Just stumbled upon this issue at work, would be great to have it merged 🙂 |
8b2fe58
to
69fb99a
Compare
any news on this ? |
If it helps, we are using this PR (via https://www.npmjs.com/package/patch-package) and its working great! Thx @mwilliamson |
I wonder if rebasing on latest master will clear up that build error. |
We ran into a bug caused by this issue. Would be nice to see this PR introduced! |
Any news on this? |
Please, merge the PR :) Please |
Can this be merged? It would come in very handy for me on a project |
Really looking forward to this! |
I'm closing this since it seems like it's not going to be merged. Regardless, when I was still working on a codebase using GraphQL, we switched to GraphQL Code Generator. |
This makes generated TypeScript fields optional if the
@include
directive is used. Fixes #888.