Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create --variant flag, deprecate --tag flag #1849

Merged
merged 21 commits into from
Mar 25, 2020
Merged

Create --variant flag, deprecate --tag flag #1849

merged 21 commits into from
Mar 25, 2020

Commits on Mar 25, 2020

  1. Make newlines (optional commit)

    Adam Zionts committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    fdb552f View commit details
    Browse the repository at this point in the history

  2. Change references of Apollo Engine in flags 

    These default flags were still referencing Apollo Engine instead of
Graph Manager (even though some were hidden). Additionally, this updates
the docs to be more accurate. Happy to take this commit into another PR
if you'd like!
    Adam Zionts committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    df140d8 View commit details
    Browse the repository at this point in the history

  3. Support variant flag in service:list command 

    This change supports the variant flag (with character -v) in addition to
the "tag" flag, which allows us to start using the new terminology. The
'--tag' flag is still supported, and there is verification that the two
sibling flags cannot be used together.
    Adam Zionts committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    33d6f71 View commit details
    Browse the repository at this point in the history

  4. Give deprecation warning to --tag users

    Adam Zionts committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    74bd14a View commit details
    Browse the repository at this point in the history

  5. Rename errors util to sharedMessages

    Adam Zionts committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    271982a View commit details
    Browse the repository at this point in the history

  6. Move tag flag deprecation warning to sharedMessages

    Adam Zionts committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    4549acf View commit details
    Browse the repository at this point in the history

  7. Support the variant flag in service:check 

    Also remove an unused variable in service:list
    Adam Zionts committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    373d364 View commit details
    Browse the repository at this point in the history

  8. Update service:delete to use variant flag 

    Also update description of the flags
    Adam Zionts committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    9658ff5 View commit details
    Browse the repository at this point in the history

  9. Add support to service:download to use --variant 

    Also simplify an import in apollo-language-server
Also add a XXX comment to service:download to illustrate a problem
    Adam Zionts committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    ed9bd15 View commit details
    Browse the repository at this point in the history

  10. Change magical config tag to use variant 

    Additionally, this updates the text output in the service:check command
to consistently use graph@variant everywhere
    Adam Zionts committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    5a67bbb View commit details
    Browse the repository at this point in the history

  11. Rename magical config.tag to config.variant 

    This is a find and replace all, and I verified every command still works
after this (both with --tag and --variant). Will post screenshots of how
everything looks in the PR :)
    Adam Zionts committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    a2fa163 View commit details
    Browse the repository at this point in the history

  12. Update snapshots 

    A previous commit added `@variant` everywhere, and these snapshot
updates should be ONLY that.
    Adam Zionts committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    fe93251 View commit details
    Browse the repository at this point in the history

  13. Put all handling into the magical config.variant

    Adam Zionts committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    598f2ae View commit details
    Browse the repository at this point in the history

  14. Replace all flags.tag references to config.variant

    Adam Zionts committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    272434a View commit details
    Browse the repository at this point in the history

  15. Add variant to the client: commands 

    All of the client commands share common flags, so no further changes are
required. Also, all of them use config.variant, so yay! :)
    Adam Zionts committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    3813df4 View commit details
    Browse the repository at this point in the history

  16. Warn about deprecation at magical config.variant 

    Remove the deprecation warning from specific callsites and rely on the
deprecation warning appearing when the config.variant value is set
    Adam Zionts committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    9524e26 View commit details
    Browse the repository at this point in the history

  17. Support for service:push variant 

    Also, this changes the default value of the flag, but it does NOT change
the behaviour, since `config.variant` always defaults to "current" if
flags and configuration are not set. The reason this was done is because
flags.tag will be non-null if there is a default, which causes the
deprecation message to always print
    Adam Zionts committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    5d09944 View commit details
    Browse the repository at this point in the history

  18. Changes word "tag" in some user-facing messages

    Adam Zionts committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    606e18b View commit details
    Browse the repository at this point in the history

  19. Some small tweaks in wording 

    Mainly renaming service to graph and "schema" to service, which felt a
little meh, but more in line with the name of the command
    Adam Zionts committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    5f44ed1 View commit details
    Browse the repository at this point in the history

  20. Update changelog

    Adam Zionts committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    c47a12b View commit details
    Browse the repository at this point in the history

  21. Updates snapshots to match new messaging 

    This should only include changes to some minor message changes in
service:check
    Adam Zionts committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    85e49e9 View commit details
    Browse the repository at this point in the history