-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin graphql to the ~14.2.x range #1291
Conversation
An incoming graphql release (14.3.1) is going to break at least `apollo client:check` as it did in the past (confirmed this manually with graphql's master branch). This dependency restriction will prevent this for now, without us needing to find the root of the issue. This is preventative for now until we have the resources to investigate and resolve the actual cause of the problem. For more details and full context, see: graphql/graphql-js@183ff32#r32971387
I'm slightly worried that this will cause duplicated |
@trevor-scheer is there anything I can do to help move this along? Is this a result of a breaking change inadvertantly introduced by the |
@ryami333, you're welcome to investigate and I'm happy to share what information I have with you. There's some history with trouble with recent patches of
Prior to the release of If you're interested in proposing a fix and have the time to investigate, you can reproduce by changing the graphql version to latest and running I haven't had time to investigate the issue, but I'd be happy to help anyone who's interested in doing so. Unfortunately, this path was chosen as a way to minimize damage ( |
An incoming graphql release (14.3.1) is going to break at least
apollo client:check
as it did in the past with14.2.0
(confirmed thismanually with graphql's master branch). This dependency restriction
will prevent this for now, without us needing to find the root of
the issue. This is preventative until we have the resources
to investigate and resolve the actual cause of the problem.
For more details and full context, see:
graphql/graphql-js@183ff32#r32971387
cc @abernix @martijnwalraven
TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.