Avoid TypeError when querystring is present, but query missing
#964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@steverice: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
ghost
added
The express-graphql reference implementation [provides a check] (https://github.com/graphql/express-graphql/blob/2e27a7335875f23ae5cccc97a9d6926970fb08c3/src/index.js#L201-L208) to protect against cases where a GET request is made that does not have a `query` parameter where the GraphQL query would be present. Without this guard, graphql-js's `parse` will return `undefined` for the `DocumentNode` since it has no document to read. Subsequently passing this to `isQueryOperation` results in a `TypeError`, because we are providing `undefined` where `getOperationAst` [expects to get a DocumentNode](https://github.com/graphql/graphql-js/blob/5fe39262a308df944a87cc85b225228e7556aaa4/src/utilities/getOperationAST.js#L19). A new test file is added for `runHttpQuery`, as one previously did not seem to exist.
steverice
force-pushed
the
fix-querystring-with-no-query
branch
from
1c28750
to
7ad44d1
Compare
abernix
approved these changes
Apr 16, 2018
|
Thanks, @steverice! |
|
This should be published in |
|
Working as expected :) Thanks for the review + merge! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The express-graphql reference implementation provides a check
to protect against cases where a GET request is made that does not
have a
queryparameter where the GraphQL query would be present.Without this guard, graphql-js's
parsewill returnundefinedfor theDocumentNodesince it has no document to read. Subsequently passing this toisQueryOperationresults in aTypeError, because we are providingundefinedwheregetOperationAstexpects to get a DocumentNode.A new test file is added for
runHttpQuery, as one previously did not seem to exist.TODO:
/label bug