Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a TS Code Generator "How to" article with examples #6904

Merged
merged 15 commits into from
Sep 17, 2022
Merged

Adding a TS Code Generator "How to" article with examples #6904

merged 15 commits into from
Sep 17, 2022

Conversation

rkoron007
Copy link
Contributor

Accompanying example: apollographql/docs-examples#53

@rkoron007 rkoron007 added the 📝 documentation Focuses on changes to the documentation (docs) label Sep 14, 2022
@rkoron007 rkoron007 self-assigned this Sep 14, 2022
@netlify
Copy link

netlify bot commented Sep 14, 2022 •
edited
Loading

✅ Deploy Preview for apollo-server-docs ready!

Name Link
🔨 Latest commit faf7127
🔍 Latest deploy log https://app.netlify.com/sites/apollo-server-docs/deploys/63250ffbfa0184000a90ef5f
😎 Deploy Preview https://deploy-preview-6904--apollo-server-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 14, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit faf7127:

Sandbox Source
Apollo Server Typescript Configuration
Apollo Server Configuration

@rkoron007 rkoron007 marked this pull request as ready for review September 15, 2022 17:20
trevor-scheer
trevor-scheer reviewed Sep 15, 2022
View reviewed changes
docs/source/getting-started.mdx Show resolved Hide resolved
docs/source/workflow/generate-types.mdx Outdated Show resolved Hide resolved
docs/source/workflow/generate-types.mdx Outdated Show resolved Hide resolved
docs/source/workflow/generate-types.mdx Outdated Show resolved Hide resolved
docs/source/workflow/generate-types.mdx Show resolved Hide resolved
docs/source/workflow/generate-types.mdx Outdated Show resolved Hide resolved
docs/source/workflow/generate-types.mdx Outdated Show resolved Hide resolved
trevor-scheer
trevor-scheer approved these changes Sep 16, 2022
View reviewed changes
docs/source/workflow/generate-types.mdx Outdated Show resolved Hide resolved
docs/source/workflow/generate-types.mdx Outdated Show resolved Hide resolved
docs/source/workflow/generate-types.mdx Outdated Show resolved Hide resolved
docs/source/workflow/generate-types.mdx Outdated Show resolved Hide resolved
docs/source/workflow/generate-types.mdx Outdated Show resolved Hide resolved
docs/source/workflow/generate-types.mdx Show resolved Hide resolved
@rkoron007
Copy link
Contributor Author

I don't know exactly what I did to double the commit history here, but I double-checked the files themselves and everything looks fine. 😅 This should be ready for re-review in any case @trevor-scheer, I can also try and fix that git history if you think it's a problem!

@trevor-scheer
Copy link
Member

@rkoron007 probably just a rebase, github can handle them a bit funny but it seems like it's cleared up!

@rkoron007 rkoron007 merged commit e2f6269 into version-4 Sep 17, 2022
@rkoron007 rkoron007 deleted the RK/AS4-add-codegen branch September 17, 2022 00:13
@charlypoly
Copy link

@rkoron007 @trevor-scheer

Hi 👋🏼

I am Charly, working at The Guild, especially on the GraphQL Code Generator project ⚡
I added some comments on the PR; let me know if you would be interested in having a PR proposing those changes.

@rkoron007 rkoron007 mentioned this pull request Sep 20, 2022
Merged
@rkoron007 rkoron007 mentioned this pull request Sep 20, 2022
Merged
@hwillson hwillson mentioned this pull request Sep 21, 2022
Closed
rkoron007 added a commit that referenced this pull request Sep 22, 2022
@rkoron007
TypeGen article second pass to incorporate additional feedback from #…
2eaec33 
…6904 (#6932)
@charlypoly charlypoly mentioned this pull request Oct 11, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trevor-scheer trevor-scheer trevor-scheer approved these changes

@charlypoly charlypoly charlypoly left review comments

@glasser glasser glasser left review comments

@StephenBarlow StephenBarlow Awaiting requested review from StephenBarlow

Assignees

@rkoron007 rkoron007

Labels
📝 documentation Focuses on changes to the documentation (docs)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rkoron007 @trevor-scheer @charlypoly @glasser