Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added vhost option for Hapi #611

Merged
merged 3 commits into from
Oct 16, 2017
Merged

Added vhost option for Hapi #611

merged 3 commits into from
Oct 16, 2017

Conversation

robinvdvleuten
Copy link
Contributor

@robinvdvleuten robinvdvleuten commented Oct 10, 2017 •
edited
Loading

Hi there!

I've added the option to add a vhost to the endpoint, as it should be allowed by Hapi route configuration.

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@martijnwalraven martijnwalraven merged commit d06a19a into apollographql:master Oct 16, 2017
@dependencies dependencies bot mentioned this pull request Mar 19, 2018
Open
@rmoura-92
Copy link

any way to add this for express package? thanks

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robinvdvleuten @rmoura-92 @martijnwalraven