Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typeDefs): allow Array<string | DocumentNode> #5978

Merged
merged 4 commits into from
Jan 5, 2022

Conversation

chentsulin
Copy link
Contributor

makeExecutableSchema accepts Array<DocumentNode | string>, so I think this should be allowed too.

@glasser
Copy link
Member

glasser commented Jan 5, 2022

Good catch. I've taken it one step farther by having us use the types from @graphql-tools/schema directly. (In general it's not great when the types of our arguments are tied directly to third-party package arguments, but in this case all we ever do with these options is pass them to that package, and you can avoid this codepath by passing your own schema anyway.)

@glasser glasser enabled auto-merge (squash) January 5, 2022 22:49
@glasser glasser merged commit dad2cdd into apollographql:main Jan 5, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants