apollo-server-core: Fix delayed shutdown bug in schemaReporter.ts #5222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndScheduleNext() is suspended would still result in setTimeout() being called.
glasser
approved these changes
May 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR,
schemaReporter.tsis changed to fix a bug where callingstop()may not prevent functions from being executed in the future viasetTimeout(). The specific case is when:sendOneReportAndScheduleNext()is suspended while waiting on a response from Studio.stop()is called and finishes execution.sendOneReportAndScheduleNext()resumes execution, and callssetTimeout()to schedule another invocation ofsendOneReportAndScheduleNext()some time in the future (usually 60 seconds).sendOneReportAndScheduleNext()executes in the future, but early-returns because it checksthis.isStopped().The end result is Node being prevented from clean shutdown for ~60 seconds in such cases.