Update graphql-tools to v7 scoped packages and simplify dependency #5183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that a previous commit on `release-3.0` stopped exporting all `graphql-tools` exports from our packages, but the docs had not yet been updated. - Update from `graphql-tools@4` to the newest version of various `@graphql-tools/X` packages. - Make it clear that the use of `graphql-tools` functionality in Apollo Server is essentially a convenience for the most common use cases, and that folks who want to use detailed `graphql-tools` functionality are welcome to do so directly. - Remove support for `schemaDirectives`. This `makeExecutableSchema` option is considered to be legacy by `graphql-tools` these days, so this seems like a reasonable time to drop it from the Apollo Server API. Folks who want to keep using it can use `makeExecutableSchema` from `@graphql-tools/schema` directly, or ideally switch to the newer `schemaTransforms`. Stop documenting it. - Remove most docs that just duplicate `graphql-tools` docs. (Keep some of the mocking docs.) - Update mocking support to use `addMocksToSchema` from `@graphql-tools/mock` rather than `addMockFunctionsToSchema` from `graphql-tools`. Note that this has some backwards-incompatible changes, mentioned in the CHANGELOG. Update docs to not claim you can look at arguments in mock functions (that's one of those changes). Document alternative to deprecated `MockList` class. Remove skipped test because presumably the "bug" is by this point expected behavior. - Only apply mocks to schema in the non-`gateway` codepath rather than to schemas provided by the gateway (at startup or later via `onSchemaChange`). Assuming your `gateway` is an `ApolloGateway`, this should be a no-op as `ApolloGateway` provides an `executor` which never calls resolvers on the schema. If you have implemented your own `gateway` which does not have an executor that entirely ignores resolvers, you can always add mocks to the schema returned from `load` and sent to `onSchemaChange` yourself. Inspired by #4237 by @yaacovCR. Fixes #4923.
|
In the interest of velocity (eg, I want to make some alphas today) I'm going to merge this without review but I definitely want feedback on this soon! |
| // to generate a random integer | ||
| friends: [...new Array(casual.integer(2, 6))], | ||
| // a list of three lists of two items: [[1, 1], [2, 2], [3, 3]] | ||
| listOfLists: () => [...new Array(3)].map((i) => [...new Array(2)]), |
There was a problem hiding this comment.
Noticed this on a drive-by
Suggested change
| listOfLists: () => [...new Array(3)].map((i) => [...new Array(2)]), | |
| listOfLists: () => [...new Array(3)].map((_, i) => [i, i]), |
There was a problem hiding this comment.
I adapted this from the graphql-tools docs (which I suspect were adapted from these docs in the first place) FWIW. I don't know enough about list mocking to know if the undefineds in the lists are relevant or not.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that a previous commit on
release-3.0stopped exporting allgraphql-toolsexports from our packages, but the docs had not yet beenupdated.
graphql-tools@4to the newest version of various@graphql-tools/Xpackages.graphql-toolsfunctionality in ApolloServer is essentially a convenience for the most common use cases, and
that folks who want to use detailed
graphql-toolsfunctionality arewelcome to do so directly.
schemaDirectives. ThismakeExecutableSchemaoption is considered to be legacy by
graphql-toolsthese days, sothis seems like a reasonable time to drop it from the Apollo Server
API. Folks who want to keep using it can use
makeExecutableSchemafrom
@graphql-tools/schemadirectly, or ideally switch to the newerschemaTransforms. Stop documenting it.graphql-toolsdocs. (Keep someof the mocking docs.)
addMocksToSchemafrom@graphql-tools/mockrather thanaddMockFunctionsToSchemafromgraphql-tools. Note that this has some backwards-incompatiblechanges, mentioned in the CHANGELOG. Update docs to not claim you can
look at arguments in mock functions (that's one of those changes).
Document alternative to deprecated
MockListclass. Remove skippedtest because presumably the "bug" is by this point expected behavior.
gatewaycodepath rather thanto schemas provided by the gateway (at startup or later via
onSchemaChange). Assuming yourgatewayis anApolloGateway, thisshould be a no-op as
ApolloGatewayprovides anexecutorwhichnever calls resolvers on the schema. If you have implemented your own
gatewaywhich does not have an executor that entirely ignoresresolvers, you can always add mocks to the schema returned from
loadand sent to
onSchemaChangeyourself.Inspired by #4237 by @yaacovCR. Fixes #4923.