Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatResponse typings #5089

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Fix formatResponse typings #5089

merged 1 commit into from
Apr 6, 2021

Conversation

glasser
Copy link
Member

@glasser glasser commented Apr 6, 2021

This typing was added in #3431; it looks like we put the | null in the wrong
place. Fortunately, a function that's OK with accepting a null argument and will
never return null can still typecheck with the new type.

Fixes #5009.

@glasser glasser force-pushed the glasser/formatresponse-typings branch from fd9ef3d to e79c8d9 Compare April 6, 2021 21:56
@glasser glasser enabled auto-merge (squash) April 6, 2021 21:56
This was referenced Apr 6, 2021
Closed
Closed
@glasser
Fix formatResponse typings
9825c40 
This typing was added in #3431; it looks like we put the `| null` in the wrong
place. Fortunately, a function that's OK with accepting a null argument and will
never return null can still typecheck with the new type.

Fixes #5009.
@glasser glasser force-pushed the glasser/formatresponse-typings branch from e79c8d9 to 9825c40 Compare April 6, 2021 22:03
@glasser glasser merged commit ad4c3ac into main Apr 6, 2021
@glasser glasser deleted the glasser/formatresponse-typings branch April 6, 2021 22:11
abernix
abernix reviewed Apr 7, 2021
View reviewed changes
Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@glasser
Copy link
Member Author

glasser commented Apr 9, 2021

I've released a prerelease with this fix, version 2.23.0-alpha.0. Try out the alpha and see if it works for you! Please provide any feedback in #5094.

@glasser
Copy link
Member Author

glasser commented Apr 14, 2021

This is released in Apollo Server 2.23.0.

@glasser glasser mentioned this pull request Sep 29, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abernix abernix abernix left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

formatResponse typings: null response?
2 participants
@glasser @abernix