Edits to updates for stop method and related #4914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glasser
approved these changes
Feb 9, 2021
| This option is used only by the `apollo-server` package. If you're integrating with Node.js middleware via a different package, it's your responsibility to stop your HTTP server in whatever way is appropriate. | ||
| **This option is used only by the `apollo-server` package.** If you're integrating with [Node.js middleware](../integrations/middleware/) via a different package, it's your responsibility to stop your HTTP server in whatever way is appropriate. | ||
|
|
||
| The default value is `10000` (10 seconds). |
There was a problem hiding this comment.
Probably easier to read as 10_000 (a change I should also make in the actual code!)
|
|
||
| You provide your `willResolveField` handler in the object returned by your [`executionDidStart`](#executiondidstart) handler. | ||
|
|
||
| Your `willResolveField` handler can optionally return an ["end hook"](#end-hooks) function that's invoked with the resolver's result (or the error that it throws). The end hook is called when your resolver has _fully_ resolved (i.e., if the resolver returns a Promise, the hook is called with the Promise's eventual resolved result). |
There was a problem hiding this comment.
Probably more of an e.g. than an i.e. as there are other things like "returning a Promise resolving to an array of Promises resolving to lists of Promises"
glasser
added a commit
that referenced
this pull request
Feb 9, 2021
…4913) v2.20 has two changes related to `stop`, so this is a good time to actually document it! Fixes #4104. Includes #4914. Co-authored-by: Stephen Barlow <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.