Upgrade graphql-upload to support Node.js v14

[Leko]

Hi there!
I've updated graphql-upload to v10 to support Node.js v14. The documentation(docs/source/data/file-uploads.md) has already been updated to call createReadStream, but test codes ware still accessing the stream property, so I've updated the test codes.

fix #3508 and fix #3579

[apollo-cla]

@Leko: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

[abernix]

Thanks for opening this! Are there any other breaking changes to the exposed API (e.g. the uploadsConfig configuration object) that end users need to be concerned with?

In other words, is this okay to introduce in a 2.x release?

[Leko]

Hi @abernix!
uploadsConfig (FileUploadOptions) hasn't changed between v8 and v10 (documentation).

In other words, is this okay to introduce in a 2.x release?

I think It's OK for me but not for all end users. Especially, end users need to migrate to file.createReadStream() from file.stream. If users are already doing so, there is no breaking change.
Does my answer make sense?

[abernix]

It does make sense, but it sounds like we'd still need to put this in a major release to me. Thanks for the clarity.

[Vultraz]

Would this be in 3.x, then?

[jaydenseric]

Note that graphql-upload v11.0.0 is out.

[savnik]

Updating will also solve this issue/bug #3508 with fs-capacitor. In our case we can remove the forced resolution of version 5.0.0 in our package.json files.

[savnik]

Update this to version 11.0.0 as noted by @jaydenseric.
One of the changes in version 11.0.0 is that graphql-upload is actaually CI tested for node version 14.
Version 10.0.0 of graphql-upload is not CI tested for node version 14. See release notes here: https://github.com/jaydenseric/graphql-upload/releases

[standy]

If I'm not wrong, the next major release is only 30% complete and doesn't have a date.

This fix is pretty crucial and should be released sooner is better, because for now apollo-server doesn't work with current nodejs versions properly

[gengjiawen]

If I'm not wrong, the next major release is only 30% complete and doesn't have a date.

This fix is pretty crucial and should be released sooner is better, because for now apollo-server doesn't work with current nodejs versions properly

@abernix Anything you can do to push this a little forward ?

[abenhamdine]

@Leko could you update your PR to change grapqhl-upload version to 11 ?
It's currently blocking the approval

thx !

[Leko]

@abenhamdine I'm sorry for my late reply. I've updated graphql-upload to 11.x.

[savnik]

LGTM

[Vultraz]

Did this get handled elsewhere?

[abenhamdine]

Did this get handled elsewhere?

I don't think, see #4304

[strigona-worksight]

Any updates on when this might be merged?

[Noloxe-Fred]

Any updates on when this might be merged?

Same question ;)

[abernix]

To those that are inquiring, I posted a suggestion / update on the issue here: #3508 (comment)

[JCMais]

For those that cannot wait and are receiving TypeError: _graphql.GraphQLScalarType is not a constructor on Node.js 14, add this to the resolutions on your package.json (this only works if you use Yarn):

    "**/apollo-server-core/graphql-upload": "^11.0.0",

[sakulstra]

It does make sense, but it sounds like we'd still need to put this in a major release to me. Thanks for the clarity.

Couldn't we do a major release with this and rebrand the other upcoming changes to v4?
Seems like apollo-server has fallen behind in some dependencies (^this gql-upload, but also graphql, apollo-tools et al) resulting in quite some resolution work to not break our toolchain 😅

[woowebsite]

after upgrade fs-capacitor in apollo-server-core/node_modules/fs-capacitor to version 6.2.0 I have resolved.
I use Nodejs 14

[alvis]

On node 15, npm v7 even gives a warning when installing apollo-server as graphql-upload v8 doesn't support graphql v15. :/

[simontaisne]

Is there any reason for not going ahead with this PR?

[savnik]

@simontaisne I think that the point form @abernix is to put it in the next major release because of the breaking changes.
But it could be nice with an update :-)

[glasser]

As described in #3508 (comment) we will be removing the default graphql-upload integration in Apollo Server 3, so we won't be upgrading it. @abernix has commented above with instructions on how to use graphql-upload directly in Apollo Server 2.