Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency graphql to v15 #3953

Closed
wants to merge 4 commits into from
Closed

chore(deps): update dependency graphql to v15 #3953

wants to merge 4 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 5, 2020 •
edited
Loading

This PR contains the following updates:

Package Type Update Change
graphql devDependencies major 14.6.0 -> 15.0.0

Release Notes

graphql/graphql-js

v15.0.0

Compare Source

v15.0.0 (2020-04-02)

Breaking Change 💥
New Feature 🚀
Bug Fix 🐞
Docs 📝
7 PRs were merged
Polish 💅
98 PRs were merged
Internal 🏠
29 PRs were merged
Dependency 📦
35 PRs were merged
Committers: 16

Renovate configuration

📅 Schedule: "every weekend" in timezone America/Los_Angeles.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the dependencies label Apr 5, 2020
@renovate renovate bot force-pushed the renovate/graphql-15.x branch 3 times, most recently from a1eb2c9 to 56f8ce0 Compare April 11, 2020 10:33
@renovate renovate bot force-pushed the renovate/graphql-15.x branch 7 times, most recently from 3631cb6 to 71611dc Compare April 25, 2020 07:27
@renovate renovate bot force-pushed the renovate/graphql-15.x branch 4 times, most recently from ce42d22 to e40eec2 Compare May 2, 2020 07:38
@renovate renovate bot force-pushed the renovate/graphql-15.x branch 5 times, most recently from 4115435 to d931d4f Compare May 2, 2020 15:27
@renovate renovate bot force-pushed the renovate/graphql-15.x branch from d931d4f to 6919c38 Compare May 2, 2020 17:27
@abernix
Update error message with new expectation from graphql@15.
b0cb7bf
@abernix
Update snapshots for graphql@15's preservation of user-type sortation.
4ae1106 
The order of types returned by, e.g. `getImplementation`, will now be
dependent on the order that those types first appear in the schema.

See the referenced issues, the first of which implemented the change and the
second which indicates the motivation.

Ref: graphql/graphql-js#2410
Ref: graphql/graphql-js#2362
@renovate
Copy link
Contributor Author

renovate bot commented May 5, 2020 •
edited
Loading

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

If you think this comment is in error and the branch is not modified, try deleting this comment. If it comes back again the next time Renovate runs, please submit an issue or seek config help.

Base automatically changed from master to main June 24, 2020 18:17
@renovate
Copy link
Contributor Author

renovate bot commented Jul 6, 2020

Autoclosing Skipped

This PR has been flagged for autoclosing, however it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

@nikolayandr
Copy link

Guys, are there any plans to apply this MR?

@kosmos
Copy link

kosmos commented Jul 15, 2020

Please, apply this MR.

This was referenced Sep 7, 2020
Merged
Open
@abernix
Copy link
Member

abernix commented Sep 15, 2020

@nikolayandr, @kosmos, others: Due to the (intentional) design of the package itself, the grahpql dependency is a peerDependency of Apollo Server, meaning it is to be installed directly by the end user and is not packaged with apollo-server* packages. This PR bumps the devDependencies Apollo Server to use graphql — meaning the version we actually test against in CI and use during local development of the server itself.

Other PRs have directly addressed the changes necessary to actually support graphql@15 in user's applications, and including the bump to the range of versions that it supports. Those PRs include #3712, #3825 and #3944.

For backward compatibility, we are continuing to test Apollo Server 2.x on this main branch with graphql@14, which is why this PR — an automated PR — itself has not landed. In Apollo Server 3.x, on the https://github.com/apollographql/apollo-server/tree/release-3.0 branch, we have completed the actual upgrade to the graphql version that lives within the devDependencies and it now lives (somewhere) north of v15.0.0.

I appreciate your encouragement to apply this PR, but I hope this helps explain why this PR is intentionally not landed right now. I will close it to make that more clear, but if you are experiencing actual problems that you believe applying this PR would solve, please open or comment on issues with reproductions which demonstrate your difficulty.

Thanks!

@abernix abernix closed this Sep 15, 2020
@renovate
Copy link
Contributor Author

renovate bot commented Sep 15, 2020

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 15.x releases. However, if you upgrade to 15.x manually then Renovate will then reenable updates for minor and patch updates automatically.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

@renovate renovate bot deleted the renovate/graphql-15.x branch September 15, 2020 08:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikolayandr @kosmos @abernix @renovate-bot