-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support engine.graphVariant and APOLLO_GRAPH_VARIANT. #3924
Commits on Mar 28, 2020
-
Add deprecation warning for engine.schemaTag
Adam Zionts committedMar 28, 2020 Configuration menu - View commit details
-
Copy full SHA for 7968837 - Browse repository at this point
Copy the full SHA 7968837View commit details -
Revert "Add deprecation warning for engine.schemaTag"
This reverts commit f87d458.
Adam Zionts committedMar 28, 2020 Configuration menu - View commit details
-
Copy full SHA for 756639e - Browse repository at this point
Copy the full SHA 756639eView commit details -
Revert "Revert "Add deprecation warning for engine.schemaTag""
This reverts commit 627594b.
Adam Zionts committedMar 28, 2020 Configuration menu - View commit details
-
Copy full SHA for b4a20be - Browse repository at this point
Copy the full SHA b4a20beView commit details -
Adam Zionts committed
Mar 28, 2020 Configuration menu - View commit details
-
Copy full SHA for 4aa8e40 - Browse repository at this point
Copy the full SHA 4aa8e40View commit details
Commits on Mar 31, 2020
-
Move calculation of graphVariant into agent
The way it was before only would catch errors / print deprecation messages if the user was using a gateway. Somewhat annoyingly, the gateway and apollo server use different construction objects, so sharing the method was cleaner (since we would, in theory, like it to be possible to create an engine-reporting-agent as a class, it's important that it handles its own errors itself). This does, however, mean that a gateway Apollo Server that is using the deprecated key will get two deprecation messages, but I think it would cause more clutter to resolve that then the value it would provide to "fix" it. This also adds tests.
Adam Zionts committedMar 31, 2020 Configuration menu - View commit details
-
Copy full SHA for e88976e - Browse repository at this point
Copy the full SHA e88976eView commit details -
Add mock of console.warn to test
Additionally, since the logging is now performed by a function coming from apollo-engine-reporting, it seemed out-of-scope to add a pluggable logger to its feature set. If that's a blocker, please tell me!
Adam Zionts committedMar 31, 2020 Configuration menu - View commit details
-
Copy full SHA for 8e4bf7a - Browse repository at this point
Copy the full SHA 8e4bf7aView commit details -
Adam Zionts committed
Mar 31, 2020 Configuration menu - View commit details
-
Copy full SHA for e34789b - Browse repository at this point
Copy the full SHA e34789bView commit details -
I added these to both apollo gateway and the top-level
Adam Zionts committedMar 31, 2020 Configuration menu - View commit details
-
Copy full SHA for 1eee85a - Browse repository at this point
Copy the full SHA 1eee85aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c18ded - Browse repository at this point
Copy the full SHA 2c18dedView commit details
Commits on Apr 1, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 3383b8e - Browse repository at this point
Copy the full SHA 3383b8eView commit details
Commits on Apr 2, 2020
-
Co-Authored-By: Jesse Rosenberger <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0a3f799 - Browse repository at this point
Copy the full SHA 0a3f799View commit details -
Apply Jesse's suggestion from code review
Co-Authored-By: Jesse Rosenberger <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7d9bd3e - Browse repository at this point
Copy the full SHA 7d9bd3eView commit details -
Update packages/apollo-server-core/src/__tests__/ApolloServerBase.tes…
…t.ts Co-Authored-By: Jesse Rosenberger <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 96e1ceb - Browse repository at this point
Copy the full SHA 96e1cebView commit details
Commits on Apr 13, 2020
-
Update packages/apollo-server-core/src/__tests__/ApolloServerBase.tes…
…t.ts Co-Authored-By: Jesse Rosenberger <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6f6f0c9 - Browse repository at this point
Copy the full SHA 6f6f0c9View commit details
Commits on Apr 15, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 00b7962 - Browse repository at this point
Copy the full SHA 00b7962View commit details -
Adam Zionts committed
Apr 15, 2020 Configuration menu - View commit details
-
Copy full SHA for 05d80cf - Browse repository at this point
Copy the full SHA 05d80cfView commit details
Commits on Apr 17, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 75918ca - Browse repository at this point
Copy the full SHA 75918caView commit details
Commits on Apr 21, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ebf8474 - Browse repository at this point
Copy the full SHA ebf8474View commit details -
Configuration menu - View commit details
-
Copy full SHA for a852ea8 - Browse repository at this point
Copy the full SHA a852ea8View commit details
Commits on Apr 23, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 54095f0 - Browse repository at this point
Copy the full SHA 54095f0View commit details