Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support engine.graphVariant and APOLLO_GRAPH_VARIANT. #3924

Merged
merged 20 commits into from
Apr 23, 2020

Commits on Mar 28, 2020

  1. Add deprecation warning for engine.schemaTag

    Adam Zionts committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    7968837 View commit details
    Browse the repository at this point in the history
  2. Revert "Add deprecation warning for engine.schemaTag"

    This reverts commit f87d458.
    Adam Zionts committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    756639e View commit details
    Browse the repository at this point in the history
  3. Revert "Revert "Add deprecation warning for engine.schemaTag""

    This reverts commit 627594b.
    Adam Zionts committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    b4a20be View commit details
    Browse the repository at this point in the history
  4. Revert docs change, fix docs

    Adam Zionts committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    4aa8e40 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2020

  1. Move calculation of graphVariant into agent

    The way it was before only would catch errors / print deprecation
    messages if the user was using a gateway. Somewhat annoyingly, the
    gateway and apollo server use different construction objects, so sharing
    the method was cleaner (since we would, in theory, like it to be
    possible to create an engine-reporting-agent as a class, it's important
    that it handles its own errors itself). This does, however, mean that a
    gateway Apollo Server that is using the deprecated key will get two
    deprecation messages, but I think it would cause more clutter to resolve
    that then the value it would provide to "fix" it.
    
    This also adds tests.
    Adam Zionts committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    e88976e View commit details
    Browse the repository at this point in the history
  2. Add mock of console.warn to test

    Additionally, since the logging is now performed by a function coming
    from apollo-engine-reporting, it seemed out-of-scope to add a pluggable
    logger to its feature set. If that's a blocker, please tell me!
    Adam Zionts committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    8e4bf7a View commit details
    Browse the repository at this point in the history
  3. Add changelog entry

    Adam Zionts committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    e34789b View commit details
    Browse the repository at this point in the history
  4. Add CHANGELOG entries

    I added these to both apollo gateway and the top-level
    Adam Zionts committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    1eee85a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2c18ded View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2020

  1. Configuration menu
    Copy the full SHA
    3383b8e View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2020

  1. Update CHANGELOG.md

    Co-Authored-By: Jesse Rosenberger <[email protected]>
    zionts and abernix authored Apr 2, 2020
    Configuration menu
    Copy the full SHA
    0a3f799 View commit details
    Browse the repository at this point in the history
  2. Apply Jesse's suggestion from code review

    Co-Authored-By: Jesse Rosenberger <[email protected]>
    zionts and abernix authored Apr 2, 2020
    Configuration menu
    Copy the full SHA
    7d9bd3e View commit details
    Browse the repository at this point in the history
  3. Update packages/apollo-server-core/src/__tests__/ApolloServerBase.tes…

    …t.ts
    
    Co-Authored-By: Jesse Rosenberger <[email protected]>
    zionts and abernix authored Apr 2, 2020
    Configuration menu
    Copy the full SHA
    96e1ceb View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2020

  1. Update packages/apollo-server-core/src/__tests__/ApolloServerBase.tes…

    …t.ts
    
    Co-Authored-By: Jesse Rosenberger <[email protected]>
    zionts and abernix authored Apr 13, 2020
    Configuration menu
    Copy the full SHA
    6f6f0c9 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2020

  1. Configuration menu
    Copy the full SHA
    00b7962 View commit details
    Browse the repository at this point in the history
  2. Use custom logger

    Adam Zionts committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    05d80cf View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2020

  1. Configuration menu
    Copy the full SHA
    75918ca View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2020

  1. Configuration menu
    Copy the full SHA
    ebf8474 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a852ea8 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2020

  1. Configuration menu
    Copy the full SHA
    54095f0 View commit details
    Browse the repository at this point in the history